fix: issue where NotImplmeneted error was not raised #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
force-pushed
the
fix/rpc-not-impl
branch
from
0143178
to
ea8f947
Compare
fubuloubu
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I noticed for all the dev providers, when calling a method that didnt exist (such as debug_traceCall in non-updated hardhat nodes), it would not fail with
NotImplementederror. We have some other logic in trace mgmt that depends on these errors being raised so this PR fixes it here in core.How I did it
I figured this was shareable, small enough, and generic enough to just put in core.
I noticed this problem when trying to repro #1777 ; it did cause some issues for my in my coverage , but not the same as the ones from the issue so im not sure how related it is.
How to verify it
Checklist