refactor: use build artifacts from compilers in project.compiler_data [APE-1495]
#1719
Conversation
vany365
changed the title
project.compiler_dataproject.compiler_data [APE-1495]
| @@ -111,6 +111,23 @@ solidity = compilers.get_compiler("solidity", settings=settings["solidity"]) | |||
| vyper.compile([Path("path/to/contract.sol")]) | |||
| ``` | |||
|
|
|||
| ### Settings Artifacts | |||
|
|
|||
| Compiler build artifacts can be found in the the `<project>/.build/compilers.json` file. | |||
There was a problem hiding this comment.
actually, not sure if this location makes sense, because the Compiler object in the manifest is not expected to be a link to another file.
can probably just be stored directly in the <project>/.build/__local__.json file
There was a problem hiding this comment.
I though we were going to keep everything separate so people to be choosier about the files they need to host and stuff? Didn't we chat about that recently on GitHub somewhere?
There was a problem hiding this comment.
I suppose the contract types being separate is probably ok enough for now.
There was a problem hiding this comment.
I'm realizing this is a much bigger refactor ... Dependencies heavily rely on the compiler data already and messing with local.json is giving me a chicken and egg problem right now. Closing for now.
antazoey
force-pushed
the
feat/compiler-settings-out
branch
from
2ddf938
to
bf6cd4e
Compare
What I did
partially fixes #1590
How I did it
ape-solidityandape-vyperdepend on to actually accomplish the goal.ape-solidityandape-vyper, there will be more end-to-end testing because they are responsible for creating such data and we can see that both it'll be created and show up in the extracted manifest correctlyHow to verify it
Checklist