-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issues preventing deploy transaction errors from being very useful [APE-1141] #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vany365
changed the title
fix: issues preventing deploy transaction errors from being very useful
fix: issues preventing deploy transaction errors from being very useful [APE-1141]
Jun 29, 2023
fubuloubu
reviewed
Jun 29, 2023
antazoey
force-pushed
the
feat/delegate-enrich-error
branch
from
June 30, 2023 20:49
79c4e27
to
fe158d4
Compare
fubuloubu
reviewed
Jun 30, 2023
fubuloubu
previously approved these changes
Jul 3, 2023
dtdang
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
ape test
for failed deploy txns that were customape.reverts()
in scripts.ape.reverts()
will now return an object that eventually gets its error value set (much like pytest.raises()!!)NOTE: Requires this PR from
ape-solidity
: ApeWorX/ape-solidity#112nothing needed in vyper.
How I did it
How to verify it
Checklist