Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issues preventing deploy transaction errors from being very useful [APE-1141] #1510

Merged
merged 9 commits into from
Jul 3, 2023

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Jun 29, 2023

What I did

  • Fixes an issue where contract logic errors were not enriched during failed deploy txns
  • Fixes an issue where contract logic errors did not show traceback during failed deploy txns
  • Fixes an issue where could not make assertions in ape test for failed deploy txns that were custom
  • Fixes an issue where didnt have access to the contract type for failed deploys
  • Feature: can now use ape.reverts() in scripts.
  • Feature: ape.reverts() will now return an object that eventually gets its error value set (much like pytest.raises()!!)
  • refactor: use walrus operator more often and save some lines of code

NOTE: Requires this PR from ape-solidity: ApeWorX/ape-solidity#112
nothing needed in vyper.

How I did it

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@vany365 vany365 changed the title fix: issues preventing deploy transaction errors from being very useful fix: issues preventing deploy transaction errors from being very useful [APE-1141] Jun 29, 2023
docs/userguides/testing.md Outdated Show resolved Hide resolved
src/ape/__init__.py Show resolved Hide resolved
@antazoey antazoey requested a review from fubuloubu July 3, 2023 14:54
fubuloubu
fubuloubu previously approved these changes Jul 3, 2023
docs/userguides/testing.md Outdated Show resolved Hide resolved
@antazoey antazoey merged commit 7fc8ed8 into ApeWorX:main Jul 3, 2023
@antazoey antazoey deleted the feat/delegate-enrich-error branch July 3, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants