feat: add default yaml config #1157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wakamex
commented
Nov 28, 2022
Comment on lines
+14
to
+19
| # alchemy: | ||
| # min_retry_delay: 1_000 # 1 second delay on fail | ||
| # retry_backoff_factor: 2 # explonential backoff | ||
| # max_retry_delay: 30_000 # 30 seconds | ||
| # max_retries: 3 | ||
| # retry_jitter: 250 # 250 milliseconds |
There was a problem hiding this comment.
like this @fubuloubu? 😉 (re: getting provider settings from Config)
4 tasks
|
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
|
This PR was closed because it has been inactive for 35 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
attempt to pull out all the defaults from code into a single yaml
Why I did it
this can be used to transparently add more detailed parameters, like in ApeWorX/ape-alchemy#35. also allows non-coder users to understand what the default settings are, and to easily override them.
How I did it
removed parameters and hard-coded them into the standard yaml. maybe a separate
default-config.yamlwould be better thanape-config.yaml.replaced the context-based test_config with an overload to the default config that executes additional overrides (I bet this is causing lots of test failures):
= 195 failed, 512 passed, 3 skipped, 7 xfailed, 15 warnings, 31 errors in 1125.89s (0:18:45) =How to verify it
possibly additional tests should be needed, though i got it working with test_config.py
Checklist
default-config.yaml, distinct fromape-config.yaml