refactor!: use name instead of data_folder for accounts (#2025)

src/ape/api/accounts.py

@@ -1,3 +1,4 @@
+import os
 from pathlib import Path
 from typing import TYPE_CHECKING, Any, Iterator, Optional, Union
 
@@ -402,9 +403,11 @@ class AccountContainerAPI(BaseInterfaceModel):
     """
 
     """
-    The path to the account's data.
+    The name of the account container.
+    For example, the ``ape-ledger`` plugin
+    uses ``"ledger"`` as its name.
     """
-    data_folder: Path
+    name: str
 
     """
     The type of account in this container.
@@ -432,6 +435,16 @@ def accounts(self) -> Iterator[AccountAPI]:
             Iterator[:class:`~ape.api.accounts.AccountAPI`]
         """
 
+    @property
+    def data_folder(self) -> Path:
+        """
+        The path to the account data files.
+        Defaults to ``$HOME/.ape/<plugin_name>`` unless overriden.
+        """
+        path = self.config_manager.DATA_FOLDER / self.name
+        path.mkdir(parents=True, exist_ok=True)
+        return path
+
     @abstractmethod
     def __len__(self) -> int:
         """
@@ -552,6 +565,19 @@ class TestAccountContainerAPI(AccountContainerAPI):
     ``AccountContainerAPI`` directly. Then, they show up in the ``accounts`` test fixture.
     """
 
+    @property
+    def data_folder(self) -> Path:
+        """
+        **NOTE**: Test account containers do not touch
+        persistant data. By default and unless overriden,
+        this property returns the path to ``/dev/null`` and
+        it is not used for anything.
+        """
+        if os.name == "posix":
+            return Path("/dev/null")
+
+        return Path("NUL")
+
     @abstractmethod
     def generate_account(self) -> "TestAccountAPI":
         """

src/ape/managers/accounts.py

@@ -46,8 +46,7 @@ def containers(self) -> dict[str, TestAccountContainerAPI]:
             t for t in self.plugin_manager.account_types if issubclass(t[1][1], TestAccountAPI)
         ]
         for plugin_name, (container_type, account_type) in account_types:
-            # Pydantic validation won't allow passing None for data_folder/required attr
-            containers[plugin_name] = container_type(data_folder="", account_type=account_type)
+            containers[plugin_name] = container_type(name=plugin_name, account_type=account_type)
 
         return containers
 
@@ -174,11 +173,7 @@ def containers(self) -> dict[str, AccountContainerAPI]:
             if issubclass(account_type, TestAccountAPI):
                 continue
 
-            accounts_folder = data_folder / plugin_name
-            accounts_folder.mkdir(exist_ok=True)
-            containers[plugin_name] = container_type(
-                data_folder=accounts_folder, account_type=account_type
-            )
+            containers[plugin_name] = container_type(name=plugin_name, account_type=account_type)
 
         return containers