Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enrich_error() implementation [APE-812] #93

Merged
merged 6 commits into from
Apr 13, 2023
Merged

feat: enrich_error() implementation [APE-812] #93

merged 6 commits into from
Apr 13, 2023

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Apr 7, 2023

What I did

Goes with ApeWorX/ape#1378

Now you get fun errors like:

  File "/Users/jules/ApeProjects/ape-playground/scripts/haserror.py", line 8, in main
    contract.withdraw(sender=other)

ERROR: (Unauthorized) addr=0xc89D42189f0450C2b2c3c61f58Ec5d628176A1E7, counter=123

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@NotPeopling2day NotPeopling2day changed the title feat: enrich_error() implementation feat: enrich_error() implementation [APE-812] Apr 7, 2023
@antazoey antazoey mentioned this pull request Apr 7, 2023
Merged
3 tasks
@NotPeopling2day NotPeopling2day merged commit 94f6987 into ApeWorX:main Apr 13, 2023
@antazoey antazoey mentioned this pull request May 2, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotPeopling2day NotPeopling2day NotPeopling2day approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antazoey @NotPeopling2day