Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adhoc library linking support #89

Merged
merged 16 commits into from
Feb 9, 2023
Merged

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Feb 8, 2023

What I did

fixes: #43
Fixes: APE-324

How I did it

  • Allow libraries to be added via add_library() method.

How to verify it

  • deploy lib in tests
  • use add_library() method
  • deploy contract using lib in tests

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

README.md Outdated Show resolved Hide resolved
@antazoey
Copy link
Member Author

antazoey commented Feb 8, 2023

@antazoey antazoey changed the title feat: config driven library linking feat: library linking support Feb 8, 2023
@antazoey antazoey marked this pull request as ready for review February 8, 2023 22:37
@antazoey
Copy link
Member Author

antazoey commented Feb 8, 2023

Some of the use-case would be simpler if we merge and use this PR: ApeWorX/ape#1292

fubuloubu
fubuloubu previously approved these changes Feb 9, 2023
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let it be known I hate solidity

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
fubuloubu
fubuloubu previously approved these changes Feb 9, 2023
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the config handling, I think it would be too hard to use without deterministic deployments

@antazoey antazoey changed the title feat: library linking support feat: adhoc library linking support Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support linking libraries
2 participants