Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make settings like settings schema from solidity input JSON #68

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

antazoey
Copy link
Member

What I did

Changes settings schema to match what is defined here: https://docs.soliditylang.org/en/latest/using-the-compiler.html#input-description

(in the settings key)

How I did it

  • Removed keys that were not in the settings key
  • Changed schema / names to align with those docs.

How to verify it

Things still work and settings make sense.

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

Copy link
Contributor

@sabotagebeats sabotagebeats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antazoey antazoey merged commit 809ec9b into ApeWorX:main Aug 22, 2022
@antazoey antazoey deleted the refactor/jules/settings branch August 22, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants