Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import clash between dependency and relative path #154

Merged
merged 4 commits into from
Sep 9, 2024
Merged

fix: import clash between dependency and relative path #154

merged 4 commits into from
Sep 9, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Sep 9, 2024

What I did

fixes: #153

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey marked this pull request as ready for review September 9, 2024 20:21
@antazoey antazoey merged commit 7bea8bb into ApeWorX:main Sep 9, 2024
13 checks passed
@antazoey antazoey deleted the fix/relative-import-fix branch September 9, 2024 21:15
@derekpierre
Copy link

Tested and works for me. Thanks @antazoey - you rock 🎸 .

Now, we need to figure out ApeWorX/ape-etherscan#150 for contract verification to seamlessly work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwise-constructs bitwise-constructs bitwise-constructs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Name clash with local folder and dependency causes contract verification issue
3 participants
@antazoey @derekpierre @bitwise-constructs