Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support configured dependency cache directory #133

Merged
merged 9 commits into from
Feb 27, 2024

Conversation

mikeshultz
Copy link
Member

@mikeshultz mikeshultz commented Feb 8, 2024

What I did

Adds support for new cache_folder config var which defines where to place non-project dependencies.

Example config:

name: ape-project

compile:
  cache_folder: .cache

Depends on: ApeWorX/ape#1897

How I did it

Replaces hard references to .cache to configuration. Relies on base_dir for relative paths.

How to verify it

Run against branch from above linked PR.

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

fubuloubu
fubuloubu previously approved these changes Feb 8, 2024
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Vyper need a similar one?

@mikeshultz
Copy link
Member Author

Does Vyper need a similar one?

ape-vyper doesn't leverage the dependency cache folder and the base_path change seems to work just fine.

@mikeshultz
Copy link
Member Author

mikeshultz commented Feb 19, 2024

This should be g2g after next Ape release

ETA: this PR will need to be updated with that version update as well.

@mikeshultz mikeshultz marked this pull request as ready for review February 23, 2024 22:46
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good pending @antazoey approval

Copy link
Member

@antazoey antazoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it asap!

@mikeshultz mikeshultz merged commit f186f1e into main Feb 27, 2024
23 checks passed
@mikeshultz mikeshultz deleted the feat/cache-config branch February 27, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants