Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: take into account verbosity when showing SolcError [APE-1558] #126

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

antazoey
Copy link
Member

What I did

people said the SolcError was too verbose in some cases, so now it is less so (unless you are specifically looking for verbose errors)

How I did it

Only show message if not verbose.
Else, show the full deal (like we were doing)

How to verify it

ape compile  # less error
ape compile -v DEBUG   # more error

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@vany365 vany365 changed the title fix: take into account verbosity when showing SolcError fix: take into account verbosity when showing SolcError [APE-1558] Nov 22, 2023
@antazoey antazoey enabled auto-merge (squash) November 22, 2023 14:01
@antazoey antazoey merged commit 669fa22 into ApeWorX:main Nov 22, 2023
14 checks passed
@antazoey antazoey deleted the fix/too-much-error branch November 22, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants