Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use new settings and implement compile code [APE-1512] #125

Merged
merged 11 commits into from
Nov 13, 2023

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Nov 3, 2023

What I did

feat: implement compile_code.
NOTE: required patching and releasing py-solx-c like crazy

refactor: switch to packaging.version.Version, also as part of py-solc-x upgrade;

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@vany365 vany365 changed the title feat: use new settings and implement compile code feat: use new settings and implement compile code [APE-1512] Nov 3, 2023
@antazoey antazoey marked this pull request as ready for review November 9, 2023 21:58
ape_solidity/_utils.py Outdated Show resolved Hide resolved
Comment on lines +38 to +40
Tricks the tests into thinking there are no installed versions.
This saves time because it won't actually need to install solc,
and it should still work.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@antazoey antazoey enabled auto-merge (squash) November 13, 2023 19:50
@antazoey antazoey merged commit c11e583 into ApeWorX:main Nov 13, 2023
13 checks passed
@antazoey antazoey deleted the feat/apeupgrade branch November 13, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants