Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove typing extension pin [APE-1209] #115

Merged
merged 7 commits into from
Jul 20, 2023
Merged

fix: remove typing extension pin [APE-1209] #115

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
23968d3
fix: rm typing ext pin
antazoey Jul 19, 2023
e6b0c1e
fix: address other todos
antazoey Jul 20, 2023
82bfc14
Merge branch 'main' into fix/rmtypingext
antazoey Jul 20, 2023
4abf9c5
test: ignore part of test for now
antazoey Jul 20, 2023
c3413d1
chore: empty
antazoey Jul 20, 2023
66565f8
test: ignore another test
antazoey Jul 20, 2023
42bc92b
chore: lint
antazoey Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@
"ethpm-types", # Use the version ape requires
"packaging", # Use the version ape requires
"requests",
"typing-extensions==4.5.0", # Can be removed onced pinned in Core.
"web3[tester]>=0.6.5,<7", # Can remove any version after eth-ape 0.6.11
],
python_requires=">=3.8,<4",
extras_require=extras_require,
Expand Down
16 changes: 4 additions & 12 deletions tests/test_compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import solcx # type: ignore
from ape import reverts
from ape.contracts import ContractContainer
from ape.exceptions import CompilerError, ContractLogicError
from ape.exceptions import CompilerError
from ethpm_types.ast import ASTClassification
from pkg_resources import get_distribution
from semantic_version import Version # type: ignore
Expand Down Expand Up @@ -419,17 +419,9 @@ def test_enrich_error_when_custom_in_constructor(compiler, project, owner, not_o


def test_enrich_error_when_builtin(project, owner, connection):
# TODO: Any version after eth-ape 0.6.11, you can uncomment this and delete the rest.
# contract = project.BuiltinErrorChecker.deploy(sender=owner)
# with pytest.raises(IndexOutOfBoundsError):
# contract.checkIndexOutOfBounds(sender=owner)

compiler = project.compiler_manager.solidity
contract_err = ContractLogicError(
revert_message="0x4e487b710000000000000000000000000000000000000000000000000000000000000032"
)
actual = compiler.enrich_error(contract_err)
assert isinstance(actual, IndexOutOfBoundsError)
contract = project.BuiltinErrorChecker.deploy(sender=owner)
with pytest.raises(IndexOutOfBoundsError):
contract.checkIndexOutOfBounds(sender=owner)


def test_ast(project, compiler):
Expand Down