-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: airplane mode (non-exact compiler version match) [APE-1161] #114
Conversation
this may not be the best way to go about this. maybe it should be in motivation is letting me use 🦧 on a plane (there's some mf'ing 🐍s on this mf'ing plane) I've been meaning to create a test to verify what triggers an attempted download on every compile. I think the ^0.8.0 in my codebase doesn't find an exact match, and tries to download it every time? w/ this PR I get this behavior:
|
Thank you! I am always running into problems when I have no internet as well |
@wakamex For future reference, you can set the solidity version in your ape-config to 0.8.19 to avoid even trying to check for more compat versions |
Maybe that should be the suggestion with the warning? |
I like the idea of the warning if you're not connected to the internet, and then it using the most recent version that's installed and matches pragma I also like the idea of it suggesting to lock your compiler version via config file if the Pragma is wider than just one version |
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
What I did
make lazy compiler match
fixes: #
How I did it
use the built-in
match
function of the pragma_spec to check if an existing (downloaded) solidity spec is a match, and if so use it. this avoids trying to download new solc versions very aggresively, which makes it impossible to compile using ape on an airplane.How to verify it
turn off your wifi and try to compile anything, without and with this PR.
Checklist