Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: way nicer error when typing an import statement wrong [APE-1152] #113

Merged

Conversation

antazoey
Copy link
Member

What I did

Better error when you type an import wrong and stuff, like this:

import "@openzeppelin/contracts/proxy/beacon/IdBeacon.sol";

see, i spelled it wrong, and it failed with FileNotFoundError which wasn't bad but was kinda unexpected.
If I let it slide to the compiler, the message was really nasty tho.

So here i made it ideal

How I did it

check for missing files and raise a nice pretty message if you find any.

How to verify it

see my sol example at top

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@vany365 vany365 changed the title feat: way nicer error when typing an import statement wrong feat: way nicer error when typing an import statement wrong [APE-1152] Jun 29, 2023
@antazoey antazoey force-pushed the fix/nicer-error-when-import-not-exists branch from a2d1948 to 2889728 Compare June 29, 2023 19:27
@antazoey antazoey force-pushed the fix/nicer-error-when-import-not-exists branch from 2889728 to efb3392 Compare June 29, 2023 19:29
@antazoey antazoey requested a review from dtdang June 29, 2023 19:45
@antazoey antazoey merged commit 2abd3c3 into ApeWorX:main Jun 29, 2023
13 checks passed
@antazoey antazoey deleted the fix/nicer-error-when-import-not-exists branch June 29, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants