Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add npm dependency [APE-1033] #108

Merged
merged 16 commits into from
Jun 26, 2023

Conversation

dtdang
Copy link
Contributor

@dtdang dtdang commented Jun 8, 2023

What I did

Add test for npm dependency

fixes: #

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@dtdang dtdang requested a review from antazoey June 8, 2023 14:57
@vany365 vany365 changed the title Test: add npm dependency Test: add npm dependency [APE-1033] Jun 8, 2023
@antazoey antazoey changed the title Test: add npm dependency [APE-1033] test: add npm dependency [APE-1033] Jun 8, 2023
antazoey
antazoey previously approved these changes Jun 13, 2023
@sabotagebeats
Copy link
Contributor

sabotagebeats commented Jun 13, 2023

the tests seem to be failing for me locally and failing in github actions. there seems to be a problem with gnosis?

short test summary info =================================================
FAILED tests/test_compiler.py::test_compile[UseYearn] - ape.exceptions.ProjectError: Version mismatch for @gnosis.pm/safe-contracts. Is 1.3.0 in ape config but 1.0.0 in packa...
FAILED tests/test_compiler.py::test_compile[SpecificVersionNoPrefix2] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[IndirectlyImportingMoreConstrainedVersion] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[CircularImport1] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[NumerousDefinitions] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[SpacesInPragma] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[ImportSourceWithNoPrefixVersion] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[OlderVersion] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[SpecificVersionRange] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[ImportSourceWithEqualSignVersion] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[RangedVersion] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[ImportingLessConstrainedVersion] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[IndirectlyImportingMoreConstrainedVersionCompanionImport] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[BuiltinErrorChecker] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[ExperimentalABIEncoderV2] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[ImportOlderDependency] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[SpecificVersionNoPrefix] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[HasError] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[VagueVersion] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[MissingPragma] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[SpecificVersionWithEqualSign] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[CircularImport2] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[Imports] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[CompilesOnce] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile[IndirectlyImportingMoreConstrainedVersionCompanion] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile_multiple_definitions_in_source - AttributeError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/Enu...
FAILED tests/test_compiler.py::test_compile_specific_order - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile_contract_with_different_name_than_file - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_compile_only_returns_contract_types_for_inputs - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_get_imports - AssertionError: assert {'.cache/Brow...gma.sol', ...} == {'.cache/Brow...gma.sol', ...}
FAILED tests/test_compiler.py::test_compiler_data_in_manifest - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_compiler.py::test_add_library - AttributeError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/Enu...
FAILED tests/test_compiler.py::test_enrich_error_when_custom - AttributeError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/Enu...
FAILED tests/test_compiler.py::test_enrich_error_when_builtin - AttributeError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/Enu...
FAILED tests/test_integration.py::test_compile_using_cli - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
FAILED tests/test_integration.py::test_force_recompile - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkefk0kl0/tests/contracts/.cache/gnosis/v1.3.0/common/...
======================================== 36 failed, 19 passed, 1 warning in 50.69s

@antazoey
Copy link
Member

@sabotagebeats This will require Ape release. The NPM PR has not merged yet and it needs to be included in the next release for CI to pick it up correctly here.

If you want to test it locally, make sure you have Ape installed in editable mode and are switched onto the PR that uses the NPM branch.

It should work then!! Ping me on Tele if it doesnt

@antazoey antazoey marked this pull request as ready for review June 19, 2023 19:03
antazoey
antazoey previously approved these changes Jun 19, 2023
@antazoey antazoey enabled auto-merge (squash) June 19, 2023 19:03
antazoey
antazoey previously approved these changes Jun 19, 2023
@antazoey antazoey self-requested a review June 26, 2023 17:55
@antazoey antazoey merged commit 7774fb4 into ApeWorX:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants