feat: AST nodes [APE-967] #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
commented
May 23, 2023
| ct_data["userdoc"] = load_dict(ct_data["userdoc"]) | ||
| ct_data["devdoc"] = load_dict(ct_data["devdoc"]) | ||
| ct_data["sourcemap"] = evm_data["bytecode"]["sourceMap"] | ||
| ct_data["ast"] = ast |
There was a problem hiding this comment.
would be nice to be able to filter out AST nodes that are specific to this contract, but not sure that is a very easy task.
(currently if 2 contracts are in same file, they have exact same AST structure)
|
wtf why is 
|
antazoey
commented
May 23, 2023
| "packaging", # Use the version ape requires | ||
| "requests", | ||
| "typing-extensions==4.5.0", # Can be removed onced pinned in Core. |
There was a problem hiding this comment.
once pydantic updates, we should be good: pydantic/pydantic#5824
fubuloubu
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
For the input JSON, you have to put
"ast"at the source level; not the contract level, for it to work.This means Ape is slightly bloated in that will have duplicate AST info when contracts are stored in the same file.
this will be needed for contract flattening (i think, based on looking at past implementation), that is why i added it
How to verify it
Can now play with the AST node in contracts.
Checklist