Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow adding dependencies from Etherscan #114

Merged
merged 6 commits into from
Feb 2, 2024
Merged

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Feb 1, 2024

What I did

You can now use dependencies from Etherscan
I needed this because I couldn't find some contracts anywhere else

fixes: #57

How I did it

How to verify it

dependencies:
  - name: Spork
    etherscan: "0xb624FdE1a972B1C89eC1dAD691442d5E8E891469"
    ecosystem: ethereum
    network: mainnet
from ape import project

spork_contract_type = project.dependencies["Spork"]["ethereum_mainnet"].Spork

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

ape_etherscan/dependency.py Outdated Show resolved Hide resolved
ape_etherscan/explorer.py Outdated Show resolved Hide resolved
ape_etherscan/explorer.py Outdated Show resolved Hide resolved
@antazoey antazoey merged commit c3fc86c into main Feb 2, 2024
25 checks passed
@antazoey antazoey deleted the feat/dependency branch February 2, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make use of source code in ABI response
2 participants