feat: add optimism sepolia testnet [APE-1488] #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vany365
changed the title
APE-1488 "feat: add optimism sepolia testnet" (ApeWorX/ape-etherscan #105)
What I didfixes: # How I did itHow to verify itChecklist
ApeWorX/ape-etherscan #105 by fubuloubu on GitHub via LinearSync |
4 tasks
|
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
antazoey
reviewed
Dec 12, 2023
| "mainnet", | ||
| "goerli", | ||
| "sepolia", |
There was a problem hiding this comment.
only addition besides ethereum's here, rest of diff is sorting
note: eth also just has sep added
antazoey
approved these changes
Dec 12, 2023
antazoey
previously approved these changes
Dec 12, 2023
|
What's going on with that new tokens file? |
no idea - deleted though |
|
tests were broken in a few ways - also was an issue with version types. |
antazoey
approved these changes
Dec 13, 2023
antazoey
added a commit
to NotPeopling2day/ape-etherscan
that referenced
this pull request
Dec 13, 2023
Co-authored-by: Juliya Smith <jules@apeworx.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
requires: ApeWorX/ape-optimism#19
How I did it
How to verify it
Checklist