chore: add more logging [APE-1328] #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabotagebeats
approved these changes
Aug 25, 2023
fubuloubu
approved these changes
Aug 25, 2023
| @@ -8,6 +8,7 @@ | |||
| from ape.logging import logger | |||
| from ape.utils import USER_AGENT, ManagerAccessMixin | |||
| from requests import Session | |||
| from yarl import URL | |||
There was a problem hiding this comment.
Should probably use this in the RPC debug in core because it's currently showing my project id lol
There was a problem hiding this comment.
hmm , I thought we were already!
Maybe this is happening in the foundry plugin when connecting to the upstream provider?
Show me where if you find it. I know ape-geth handles it well but it may be missed elsewhere.
There was a problem hiding this comment.
it was doing it for me w/ infura at least
There was a problem hiding this comment.
I am having troubles locating where this might be happening. Can you share with me what the log looks like?
There was a problem hiding this comment.
I think I was doing debug on running apepay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
In combo with ApeWorX/ape#1628 may help debug issues with using contract fetching in certain environments.
However, please let me know any other logging that will help in this process!
How I did it
How to verify it
Checklist