Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: for APE-1796, adds in gas_used_for_L1 to arbitrum receipt #32

Merged
merged 5 commits into from
Aug 12, 2024
Merged

fix: for APE-1796, adds in gas_used_for_L1 to arbitrum receipt #32

merged 5 commits into from
Aug 12, 2024

Conversation

bitwise-constructs
Copy link
Contributor

What I did

Added in the gas_used_for_L1 arbitrum property to the ape receipt

fixes: APE-1796

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

antazoey
antazoey reviewed Aug 12, 2024
View reviewed changes
Copy link
Member

@antazoey antazoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this! Can you fix the serializer and add a test?

ape_arbitrum/ecosystem.py Outdated Show resolved Hide resolved
ape_arbitrum/ecosystem.py Outdated Show resolved Hide resolved
antazoey
antazoey reviewed Aug 12, 2024
View reviewed changes
tests/test_ecosystem.py Outdated Show resolved Hide resolved
antazoey
antazoey previously approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@antazoey antazoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit in the tests, but looks good!

antazoey
antazoey approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@antazoey antazoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I know it is a bit weird with the mix and match of camelCase and snake_case, but for 0.9, all receipt fields should be JSON-ically camelCase and Pythonically snake_case.

@bitwise-constructs bitwise-constructs merged commit 7c5e8e8 into ApeWorX:main Aug 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antazoey antazoey antazoey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitwise-constructs @antazoey