fix: handle result from make_request()
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
commented
Aug 8, 2024
| @@ -203,6 +203,11 @@ def make_request(self, rpc: str, parameters: Optional[Iterable] = None) -> Any: | |||
| ) | |||
| raise cls(message) from err | |||
|
|
|||
| if isinstance(result, dict) and (res := result.get("result")): | |||
There was a problem hiding this comment.
bugfix here, does the same as ape-ethereum, thus causing eth_call (and other RPCs) to function correctly.
There was a problem hiding this comment.
@johnson2427 it processes it here (like ape core does) and returns the extracted value
this was kind of a regression because as part of the optimizations in core, switched the base class to use make_request more, causing us to reach this bug
johnson2427
reviewed
Aug 8, 2024
| @@ -184,7 +184,7 @@ def create_access_list( | |||
| def make_request(self, rpc: str, parameters: Optional[Iterable] = None) -> Any: | |||
| parameters = parameters or [] | |||
| try: | |||
| return self.web3.provider.make_request(RPCEndpoint(rpc), parameters) | |||
| result = self.web3.provider.make_request(RPCEndpoint(rpc), parameters) | |||
There was a problem hiding this comment.
If you don't want this result, I'll approve
There was a problem hiding this comment.
the result is returned later on after some processing!
johnson2427
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I tried simply connecting to base sepolia using alchemy but I was unable to make calls on contracts because it was trying to turn HexBytes(dict)
realized it was because ape-alchemy overrides make_request and does different stuff
How I did it
How to verify it
should get this know:
Checklist