Skip to content

Commit

Permalink
Hparams: Fix regression in column selector. (tensorflow#6811)
Browse files Browse the repository at this point in the history
Ensure the following properties are passed to the column selector from
the data table:

```
    [numColumnsLoaded]="numColumnsLoaded"
    [hasMoreColumnsToLoad]="hasMoreColumnsToLoad"
    (loadAllColumns)="loadAllColumns.emit()"
```

These were accidentally removed in tensorflow#6799. Caught by internal tests.
  • Loading branch information
bmd3k authored and AnuarTB committed May 3, 2024
1 parent 4c2e475 commit 54b269c
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@
<ng-template #columnSelectorModalTemplate>
<tb-data-table-column-selector-component
[selectableColumns]="selectableColumns"
[numColumnsLoaded]="numColumnsLoaded"
[hasMoreColumnsToLoad]="hasMoreColumnsToLoad"
(columnSelected)="onColumnAdded($event)"
(loadAllColumns)="loadAllColumns.emit()"
></tb-data-table-column-selector-component>
</ng-template>

Expand Down

0 comments on commit 54b269c

Please sign in to comment.