Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support selecting snapper's config, default to root #41

Merged

Conversation

maximbaz
Copy link
Contributor

@maximbaz maximbaz commented Apr 1, 2018

The current code cannot properly handle the case when multiple snapper configs exists. The IDs collide, and the description is set incorrectly.

However, we don't actually need to support multiple configs, we need only the "root" config which is where the OS resides.

This PR adds the option to select the config name, and defaults to root because that's how most people name their snapper config for the /.

/cc @ckotte

Fixes #40

@ckotte
Copy link
Contributor

ckotte commented Apr 1, 2018

I tested the fix on my system with three subvolumes and now the description is properly set.

@ckotte
Copy link
Contributor

ckotte commented Apr 1, 2018

Thanks!

@maximbaz
Copy link
Contributor Author

maximbaz commented Apr 1, 2018

@Antynea gave me contributor access to this project, since it's tested I'll go ahead with merging and making a new release because I think this is a quite important bug fix. If you have comments on this PR, we can address them afterwards.

@maximbaz maximbaz merged commit 773a8bf into Antynea:master Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants