-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#155: Disable max number of arguments Ruff Linting Rule [PLR0913] #312
#155: Disable max number of arguments Ruff Linting Rule [PLR0913] #312
Conversation
…-ruff-linting-rule--plr0913-
Hi @berkaykrc :), We have CONTRIBUTING and README files that list all the contributors to the project. You can add yourself to both files; this will show that you’ve contributed to the project and is our way of thanking those who help with the project. |
Thank you, Is it appropriate that just add myself now within this PR since you did not merge yet? |
Yeah, the PR is approved :). |
Hi @berkaykrc , I think there some missing closing tags in |
…-rule--plr0913-' of https://github.com/berkaykrc/SpotifyElectron into chores/155-disable-max-number-of-arguments-ruff-linting-rule--plr0913-
Hi @AntonioMrtz, |
I tried to squash all commits into one but looks like couldn't manage it. I needed to |
Description
This pull request includes several changes across multiple files to improve code readability by removing the
# noqa: PLR0913
comment from function definitions and adding PL0913 to ruff.toml to ignore it.Changes to function definitions:
Backend/app/spotify_electron/playlist/playlist_controller.py
: Modified theupdate_playlist
function to remove the# noqa: PLR0913
comment.Backend/app/spotify_electron/playlist/playlist_repository.py
: Modified thecreate_playlist
function to remove the# noqa: PLR0913
comment.Backend/app/spotify_electron/playlist/playlist_service.py
: Modified theupdate_playlist
function to remove the# noqa: PLR0913
comment.Backend/app/spotify_electron/song/blob/song_repository.py
: Modified thecreate_song
function to remove the# noqa: PLR0913
comment.Backend/tests/test_API/api_test_artist.py
: Modified theupdate_artist
function to remove the# noqa: PLR0913
comment.Backend/tests/test_API/api_test_user.py
: Modified theupdate_user
function to remove the# noqa: PLR0913
comment.Configuration updates:
Backend/ruff.toml
: AddedPLR0913
to the ignore list in theruff
configuration file.Commit type
chore
: updating grunt tasks etc; no production code change.Issue
#155
Potential Impact
Functions with many arguments are harder to understand, maintain, and call. Consider refactoring functions with many arguments into smaller functions with fewer arguments, or using objects to group related arguments.
Consider changing these setting in ruff.toml:
https://docs.astral.sh/ruff/settings/#lint_pylint_max-args
Assigned
@AntonioMrtz