Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#155: Disable max number of arguments Ruff Linting Rule [PLR0913] #312

Conversation

berkaykrc
Copy link
Contributor

Description

This pull request includes several changes across multiple files to improve code readability by removing the # noqa: PLR0913 comment from function definitions and adding PL0913 to ruff.toml to ignore it.

Changes to function definitions:

Configuration updates:

  • Backend/ruff.toml: Added PLR0913 to the ignore list in the ruff configuration file.

Commit type

  • chore: updating grunt tasks etc; no production code change.

Issue

#155

Potential Impact

Functions with many arguments are harder to understand, maintain, and call. Consider refactoring functions with many arguments into smaller functions with fewer arguments, or using objects to group related arguments.
Consider changing these setting in ruff.toml:
https://docs.astral.sh/ruff/settings/#lint_pylint_max-args

Assigned

@AntonioMrtz

@AntonioMrtz
Copy link
Owner

Hi @berkaykrc :),

We have CONTRIBUTING and README files that list all the contributors to the project. You can add yourself to both files; this will show that you’ve contributed to the project and is our way of thanking those who help with the project.

@berkaykrc
Copy link
Contributor Author

Hi @berkaykrc :),

We have CONTRIBUTING and README files that list all the contributors to the project. You can add yourself to both files; this will show that you’ve contributed to the project and is our way of thanking those who help with the project.

Thank you, Is it appropriate that just add myself now within this PR since you did not merge yet?

@AntonioMrtz
Copy link
Owner

Hi @berkaykrc :),
We have CONTRIBUTING and README files that list all the contributors to the project. You can add yourself to both files; this will show that you’ve contributed to the project and is our way of thanking those who help with the project.

Thank you, Is it appropriate that just add myself now within this PR since you did not merge yet?

Yeah, the PR is approved :).

@AntonioMrtz
Copy link
Owner

AntonioMrtz commented Jan 27, 2025

Hi @berkaykrc , I think there some missing closing tags in README and CONTRIBUTING :)

@berkaykrc
Copy link
Contributor Author

Hi @AntonioMrtz,
I think it should be fine now. IDE didn't warned me. I'm little rusty on HTML 😄

author berkaykrc <berkay.kirci@gmail.com> 1737923398 +0300
committer berkaykrc <berkay.kirci@gmail.com> 1738095993 +0300

chore: remove noqa comments for PLR0913 in playlist and song functions
@berkaykrc
Copy link
Contributor Author

berkaykrc commented Jan 28, 2025

I tried to squash all commits into one but looks like couldn't manage it. I needed to git push --force apparently.

@AntonioMrtz AntonioMrtz merged commit 4e9412b into AntonioMrtz:master Jan 29, 2025
@berkaykrc berkaykrc deleted the chores/155-disable-max-number-of-arguments-ruff-linting-rule--plr0913- branch February 1, 2025 21:53
@AntonioMrtz AntonioMrtz linked an issue Feb 17, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable max number of arguments Ruff Linting Rule [PLR0913]
2 participants