-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#239: Only allow audio files for song uploading #240
#239: Only allow audio files for song uploading #240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is great :) . Thanks for sharing your time and following our conventions and workflows. I did write a few minor improvements that can be done. Let me know if you need anything. Backend pipeline is failing because of an enviroment value only provided in the main repo so don't worry about it.
Electron/src/__tests__/components/Sidebar/AddSongPlayListAccordion.test.tsx
Outdated
Show resolved
Hide resolved
Electron/src/__tests__/components/Sidebar/AddSongPlayListAccordion.test.tsx
Outdated
Show resolved
Hide resolved
Electron/src/__tests__/components/Sidebar/AddSongPlayListAccordion.test.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Hi @perig99 , code looks good 👍. Thanks for sharing your time and efforts to contribute to the project. I hope too see you soon in the project, are you looking for other issues to contribute? After I merge I will add you in README and CONTRIBUTORS :) . If you find this project interesting/helpful, I'd appreciate it if you could star the repo! |
Hi @AntonioMrtz, |
Hi @perig99 I wish you the best on your master thesis! . Feel free to drop by the project whenever you like. We'll be waiting :) |
Description
Commit type
feat
: Only allow audio files for song uploadingIssue
Issue #239
Solution
This pull request resolves the problem by improving the validation and handling of file uploads, specifically for audio files: