Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/Improve-Backend-Validation #171

Merged

Conversation

aarshgupta24
Copy link
Contributor

Description

Backend validation was inconsistent in the aspect of naming

Commit type

Refactor

Issue

Validation methods that are named handle, to make all validations method consistent on both behaviour and syntax.

Solution

Rename validations using the same pattern (validate_ ) and ensure the structure and behaviour is consistent.

Proposed Changes

  • handle_playlist_create ----> validate_playlist_create
  • handle_playlist_delete_count ----> validate_playlist_delete_count
  • handle_playlist_exists ----> validate_playlist_exists
  • handle_playlist_update ----> validate_playlist_update
  • handle_song_create ----> validate_base_song_create
  • handle_song_exists ----> validate_song_exists
  • handle_song_create ----> validate_song_create

Potential Impact

Reduces the inconsistency in validation task

Assigned

@AntonioMrtz

@AntonioMrtz AntonioMrtz self-requested a review July 15, 2024 07:55
@AntonioMrtz
Copy link
Owner

@aarshgupta24 Check Ruff formatting and linting. More info here

@AntonioMrtz
Copy link
Owner

AntonioMrtz commented Jul 15, 2024

@aarshgupta24 Backend Tests fail because no enviroments are provided to github actions from forked repos. So dont worry about that

@aarshgupta24
Copy link
Contributor Author

so i have to do this ruff formatting only?

@AntonioMrtz
Copy link
Owner

so i have to do this ruff formatting only?

Yes 😀

@AntonioMrtz AntonioMrtz linked an issue Jul 15, 2024 that may be closed by this pull request
@AntonioMrtz
Copy link
Owner

Thanks for contributing @aarshgupta24 😀. Merging the PR

@AntonioMrtz AntonioMrtz merged commit fd4d4d2 into AntonioMrtz:master Jul 15, 2024
@aarshgupta24 aarshgupta24 deleted the refactor/Backend-validation branch July 15, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify Backend validations
2 participants