Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue#130: redirect to artist on click #131

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

TalhaBinNasir
Copy link
Contributor

Description

When the user clicks on "Ir al artista" in the song menu, it redirects to the artist page.

Commit type

  • feat: indicates the addition of a new feature or functionality to the project.

Issue

Clicking on "Ir al artista" does not redirect to relevant artist page

Solution

add an on click event to the button to redirect to the artist url

Proposed Changes

  • add new prop called artistName
  • add onclick event to the button
  • update test file

Potential Impact

Tests Performed

  • [] Test performed

Screenshots

Additional Tasks

Assigned

@AntonioMrtz

@AntonioMrtz
Copy link
Owner

Looks cool, thanks for contributing. I will create new frontend issues soon if you're interested in contributing. Regards. @TalhaBinNasir

@AntonioMrtz AntonioMrtz merged commit ae0aef7 into AntonioMrtz:master Apr 23, 2024
@TalhaBinNasir
Copy link
Contributor Author

Yep sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Frontend related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants