Refactoring and suggestions #334
Conversation
Add name to ci.yml Triggered only when .py files is commited
Add extra args to run in all files (default is pre-commit run) Add auto-commit all changed files from pre-commit
Feat/update workflows
Refactor all .md files in accordance with markdownlint
docs: 📝 refactor .md files
There was a problem hiding this comment.
Thanks @k1lgor for your contribution.
Overall looks good! Thanks!
Although, I left a couple of comments. Let me know your thoughts.
|
Thanks @k1lgor |
| @@ -59,7 +60,7 @@ def main( | |||
| print(f.read()) | |||
| print() | |||
|
|
|||
| try: | |||
| with contextlib.suppress(KeyboardInterrupt): | |||
There was a problem hiding this comment.
This is not what we want!
We want keyboard interrupt to kill the process.
Could you push a PR to address? @k1lgor
There was a problem hiding this comment.
This might be my bad @AntonOsika
the previous code wasn't killing the process AFAIU
I mean, we didn't change the behaviour, correct?
There was a problem hiding this comment.
Just create a PR #374 with the revert @AntonOsika @patillacode
There was a problem hiding this comment.
My bad actually – it's useful to have this!
I created an issue #394 to follow up on improving further
There was a problem hiding this comment.
I was not crazy then 😅
pre-commit-config.yamlfilespre-commit.ymlpassinbenchmark.py