-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pytest pre commit hook #210
Conversation
I am not sure if I understood exactly what we need in the issue #205 , but we are now running the tests both in the I would remove running tests on each commit and just leave it in the GH actions I'll wait for feedback |
testing pre action testing pre action testing pre action testing pre action testing pre action testing pre action testing pre action testing pre action
I am no expert on GH actions. I have invested more time than I would like to recognize trying to fix the As I mentioned before I wouldn't add the tests in as a hook, now I completely subscribe that because if we avoid running the tests as s pre-commit hook my problem with the CI goes away 😅 I'm going to remove tests being run as a hook in favor of the dedicated action already running the tests. Let me know if this work for you. |
Generally speaking it's considered bad practice to run unit tests in pre-commit. |
I agree @carlthome Leaving that to the CI. Merging, thanks! |
Closes #205
pytest
on committermcolor
(used in 'print_chat.py')