Skip to content

feat: align rules with "bpack integration manual" v3.3.30 (section B.2.2.1) #8 #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2024
Merged

feat: align rules with "bpack integration manual" v3.3.30 (section B.2.2.1) #8 #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 25 additions & 17 deletions src/FormHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,15 +129,16 @@ public function setParameter($key, $value)
$this->parameters[$key] = $value;
break;

// maximum 2 chars
// maximum 2 chars
case 'customerCountry':
if (mb_strlen($value) > 2) {
throw new BpostInvalidLengthException($key, mb_strlen($value), 2);
}
$this->parameters[$key] = (string) $value;
break;

// maximum 8 chars
// maximum 8 chars
case 'customerPostalCode':
case 'customerStreetNumber':
case 'customerBox':
if (mb_strlen($value) > 8) {
Expand All @@ -146,35 +147,42 @@ public function setParameter($key, $value)
$this->parameters[$key] = (string) $value;
break;

// maximum 20 chars
// maximum 20 chars
case 'customerPhoneNumber':
if (mb_strlen($value) > 20) {
throw new BpostInvalidLengthException($key, mb_strlen($value), 20);
}
$this->parameters[$key] = (string) $value;
break;

// maximum 32 chars
case 'customerPostalCode':
if (mb_strlen($value) > 32) {
throw new BpostInvalidLengthException($key, mb_strlen($value), 32);
// maximum 40 chars
case 'customerCompany':
case 'customerStreet':
case 'customerCity':
if (mb_strlen($value) > 40) {
throw new BpostInvalidLengthException($key, mb_strlen($value), 40);
}
$this->parameters[$key] = (string) $value;
break;

// maximum 40 chars
// sum = maximum 40 chars
case 'customerFirstName':
case 'customerLastName':
case 'customerCompany':
case 'customerStreet':
case 'customerCity':
if (mb_strlen($value) > 40) {
throw new BpostInvalidLengthException($key, mb_strlen($value), 40);
$names = array(
'customerFirstName' => $this->parameters['customerFirstName'] ?: '',
'customerLastName' => $this->parameters['customerLastName'] ?: '',
);
$names[$key] = $value;
$sum = array_sum(array_map(function ($item) {
return mb_strlen($item);
}, $names));
if ($sum > 40) {
throw new BpostInvalidLengthException($key, $sum, 40);
}
$this->parameters[$key] = (string) $value;
break;

// maximum 50 chars
// maximum 50 chars
case 'orderReference':
case 'costCenter':
case 'customerEmail':
Expand All @@ -184,21 +192,21 @@ public function setParameter($key, $value)
$this->parameters[$key] = (string) $value;
break;

// integers
// integers
case 'orderTotalPrice':
case 'orderWeight':
$this->parameters[$key] = (int) $value;
break;

// array
// array
case 'orderLine':
if (!isset($this->parameters[$key])) {
$this->parameters[$key] = array();
}
$this->parameters[$key][] = $value;
break;

// unknown
// unknown
case 'deliveryMethodOverrides':
case 'extra':
case 'extraSecure':
Expand Down
Loading