fix: Always require X11 socket in Flatpak manifest

[dabigjhall]

See: #1131 (comment)

AntiMicroX crashes without access to the X11 socket, even under Wayland, so it needs socket=x11 rather than socket=fallback-x11. This way, it always gets access to the X11 socket.

Edit: Maybe this doesn't specifically fix the issue reported in #1131, because they weren't using Flatpak. I found #1201 reported for Flatpak though, that's the one for this issue.

Fixes #1201

[pktiuk]

Applications that do not support native Wayland should use only --socket=x11 and applications that do, should use --socket=fallback-x11 and --socket=wayland. The two configurations here will make the application work on both X11 and Wayland sessions of the desktop environment.

https://docs.flatpak.org/en/latest/sandbox-permissions.html

https://docs.flathub.org/docs/for-app-authors/linter#finish-args-contains-both-x11-and-wayland

[dabigjhall]

Yes I am aware of this 😉

Most applications supporting Wayland won't bother trying to connect to the X11 socket if a Wayland socket is available. Hence the advice; only grant the X11 socket if there's no Wayland socket.

AntiMicroX does not do that. I have had limited free time to investigate deeper 😅

Why does AntiMicroX still need to connect to X11 when Wayland is available? (If you don't know I am happy to help figure it out when I have some more time!)

There could be a legitimate reason since most programs do not need to do the things that AntiMicroX does, but it also could be spurious 🤷

It probably also shouldn't crash if Wayland is present but the X11 socket isn't available, it's conceivable somebody could be running Wayland without XWayland (probably pretty unlikely today, but maybe someday 🤞) If there's a good reason to want to connect to X11 though, we'd still want socket=x11 rather than socket=fallback-x11.

[pktiuk]

Possible linked issue: #1190