added nocom crash :D #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SIMULATAN
suggested changes
Apr 6, 2022
| import java.util.Random; | ||
|
|
||
| public class NoComCrash extends Module{ | ||
| final Random r = new Random(); |
|
|
||
| public class NoComCrash extends Module{ | ||
| final Random r = new Random(); | ||
| int i = 0; |
|
|
||
| private final Setting<Boolean> autoDisable = sgGeneral.add(new BoolSetting.Builder() | ||
| .name("auto-disable") | ||
| .description("Disables module on kick.") |
There was a problem hiding this comment.
I'd rather write "Disable the module when disconnected" or smth
There was a problem hiding this comment.
i would remove this setting entirely because it is not being used at all
|
looks mostly fine. could you remove the unused variables and fix the formatting slightly (remove the 14 spaces and add a space before |
|
i have fixed my idiocy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.