Skip to content

Commit

Permalink
feat: make some icons solid
Browse files Browse the repository at this point in the history
  • Loading branch information
AnthonyPorthouse committed Nov 14, 2024
1 parent 7f40aab commit 74f0294
Show file tree
Hide file tree
Showing 10 changed files with 22 additions and 14 deletions.
1 change: 1 addition & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 7 additions & 2 deletions src/Components/AlbumHeader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import type { SongIds, Songs } from "@api/types.js";
import { useTrackList } from "@hooks/useTrackList.js";
import { Link } from "@tanstack/react-router";
import { Play, Shuffle } from "lucide-react";
import { SyntheticEvent, memo, useMemo } from "react";
import { SyntheticEvent, memo, useCallback, useMemo } from "react";
import { useTranslation } from "react-i18next";

import AlbumArt from "./AlbumArt.js";
Expand Down Expand Up @@ -76,7 +76,12 @@ function AlbumHeader({ album, tracks }: Readonly<AlbumHeaderProps>) {
<h3>{album.year}</h3>
<div className="flex flex-col gap-2">
<Button
renderIcon={() => <Play className="w-6" />}
renderIcon={useCallback(
() => (
<Play className="w-6 fill-black" />
),
[],
)}
onClick={playAll}
>
<span className="flex-grow">{t("playAll")}</span>
Expand Down
6 changes: 4 additions & 2 deletions src/Components/EpisodeListItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ function EpisodeListItem({ episode }: Readonly<EpisodeListItemProps>) {
className={`flex w-full flex-shrink-0 gap-6 md:block md:w-6`}
title={t("media:playTrack")}
>
<Play className={`w-6 flex-shrink-0 md:w-full`} />
<Play className={`w-6 flex-shrink-0 fill-black md:w-full`} />
<span className={`truncate md:hidden`}>{episode.title}</span>
</button>
);
Expand All @@ -61,7 +61,9 @@ function EpisodeListItem({ episode }: Readonly<EpisodeListItemProps>) {
className={`flex w-full flex-shrink-0 gap-6 md:block md:w-6`}
title={`Currently Playing`}
>
<Play className={`w-6 flex-shrink-0 text-green-400 md:w-full`} />
<Play
className={`w-6 flex-shrink-0 fill-green-400 text-green-400 md:w-full`}
/>
<span className={`truncate md:hidden`}>{episode.title}</span>
</div>
);
Expand Down
4 changes: 2 additions & 2 deletions src/Components/MediaControls/FullscreenButton.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useFullscreen } from "@hooks/useFullscreen";
import { Expand, Shrink } from "lucide-react";
import { Fullscreen, Shrink } from "lucide-react";
import { SyntheticEvent, memo } from "react";
import { useTranslation } from "react-i18next";

Expand Down Expand Up @@ -34,7 +34,7 @@ function FullscreenButton() {
title={t("enterFullscreen")}
onClick={fullScreen}
>
<Expand className={`w-full`} />
<Fullscreen className={`w-full`} />
</button>
);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Components/MediaControls/PauseButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ function PauseButton() {
title={t("pauseTrack")}
onClick={pause}
>
<Pause className={`w-full`} />
<Pause fill="#000" className={`w-full`} />
</button>
);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Components/MediaControls/PlayButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function PlayButton() {
title={t("playTrack")}
onClick={play}
>
<Play className={`w-full`} />
<Play className={`w-full fill-black`} />
</button>
);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Components/MediaControls/SkipButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function SkipButton() {
className={`inline-block w-12`}
title={t("nextTrack")}
>
<SkipForward className={`w-full`} />
<SkipForward fill="#000" className={`w-full`} />
</button>
);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Components/MediaControls/StopButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ function StopButton() {
title={t("stopTrack")}
onClick={stop}
>
<Square className={`w-full`} />
<Square fill="#000" className={`w-full`} />
</button>
);
}
Expand Down
4 changes: 2 additions & 2 deletions src/Components/TrackListItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ function TrackListItem({
data-tooltip-content={t("playTrack")}
data-tooltip-delay-show={1000}
>
<Play className={`w-6 md:w-full`} />
<Play className={`w-6 fill-black md:w-full`} />
</a>
</button>
);
Expand Down Expand Up @@ -80,7 +80,7 @@ function TrackListItem({
data-tooltip-content={t("currentlyPlaying")}
data-tooltip-delay-show={1000}
>
<Play className={`w-6 text-green-400 md:w-full`} />
<Play className={`w-6 fill-green-400 text-green-400 md:w-full`} />
</a>
</div>
);
Expand Down
4 changes: 2 additions & 2 deletions vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import tsconfigPaths from "vite-tsconfig-paths";
export default defineConfig({
plugins: [
MillionLint.vite({
enabled: false,
enabled: true,
}),
tsconfigPaths(),
react(),
Expand Down Expand Up @@ -176,6 +176,6 @@ export default defineConfig({
},
},
optimizeDeps: {
exclude: "node_modules/.cache/storybook",
exclude: ["node_modules/.cache/storybook"],
},
});

0 comments on commit 74f0294

Please sign in to comment.