Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tui improvements #143

Merged
merged 19 commits into from
Oct 11, 2024
Merged

Tui improvements #143

merged 19 commits into from
Oct 11, 2024

Conversation

AnthonyMichaelTDM
Copy link
Owner

fixes #138

@AnthonyMichaelTDM
feat(tui): better focus indication in search view
b3d1630
@AnthonyMichaelTDM
refactor(tui): make active component handled by new state store
d89a32b
@AnthonyMichaelTDM
refactor(tui): consolidate area_splitting logic in app.rs
73200a2
@AnthonyMichaelTDM
feat(tui): basic mouse handling infrastructure
b82bafd
@AnthonyMichaelTDM
feat(tui): implement mouse click handling for checktree
1fe34d3
@AnthonyMichaelTDM
feat(tui): implement mouse handler for playlist popup
d760bc5
@AnthonyMichaelTDM
feat(tui): mouse handler for inputbox
ab2ff7e 
clicking within the input box moves the cursor
@AnthonyMichaelTDM
refactor(tui): adjust area in mouse handler to account for border
0255673
@AnthonyMichaelTDM
feat(tui): update mouse handler for playlist popup to handle input box
cbbace8
@AnthonyMichaelTDM
feat(tui): mouse handler for sidebar
3bf1ab1 
scrolling changes selected item
clicking a selected item opens it
clicking an unselected item selects it
@AnthonyMichaelTDM
feat(tui): mouse handler for control panel
279d739 
clicking on the song progress bar seeks to where you clicked
clicking on the play/pause indicator plays/pauses the song
clicking on the volume indicator toggles mute
scrolling on the volume indicator adjusts volume
@AnthonyMichaelTDM
feat(tui): mouse handler for queue bar
b943e24 
scrolling scrolls the queue view
@AnthonyMichaelTDM
fix(tui): clear tree state(s) when switching active view
1e46707
@AnthonyMichaelTDM
feat(tui): mouse handler for Library Views
caf9227 
clicking on a branch in the tree list open/closes it
clicking on a leaf selects it
clicking on an already selected item opens it
scrolling scrolls the view

playlist view has similar mouse behavior to the popup
@AnthonyMichaelTDM AnthonyMichaelTDM mentioned this pull request Oct 11, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.31952% with 85 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tui/src/ui/components/control_panel.rs 64.10% 28 Missing ⚠️
tui/src/ui/widgets/popups/playlist.rs 26.92% 19 Missing ⚠️
...i/src/ui/components/content_view/views/playlist.rs 83.82% 11 Missing ⚠️
tui/src/ui/components/sidebar.rs 88.88% 4 Missing ⚠️
tui/src/ui/widgets/popups/mod.rs 42.85% 4 Missing ⚠️
tui/src/state/component.rs 85.00% 3 Missing ⚠️
tui/src/ui/app.rs 92.68% 3 Missing ⚠️
...src/ui/components/content_view/views/collection.rs 94.00% 3 Missing ⚠️
tui/src/ui/components/queuebar.rs 72.72% 3 Missing ⚠️
tui/src/ui/components/content_view/views/search.rs 94.59% 2 Missing ⚠️
... and 5 more 
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   84.06%   84.30%   +0.24%     
==========================================
  Files          89       90       +1     
  Lines        6211     6673     +462     
==========================================
+ Hits         5221     5626     +405     
- Misses        990     1047      +57
Components Coverage Δ
MECOMP Core 93.27% <ø> (+0.21%) ⬆️
MECOMP Daemon 61.66% <ø> (+0.10%) ⬆️
MECOMP Storage 91.15% <ø> (ø)
SurrealQLX 85.14% <ø> (ø)
OneOrMany 99.35% <ø> (ø)
Analysis 81.93% <ø> (ø)
MECOMP CLI 85.42% <ø> (+0.18%) ⬆️
MECOMP TUI 87.97% <85.31%> (-0.19%) ⬇️
Files with missing lines Coverage Δ
daemon/src/services/library.rs 69.13% <ø> (ø)
tui/src/ui/components/content_view/mod.rs 96.96% <100.00%> (+0.26%) ⬆️
tui/src/ui/components/content_view/views/none.rs 94.73% <100.00%> (+0.29%) ⬆️
tui/src/ui/components/content_view/views/radio.rs 99.13% <100.00%> (+0.19%) ⬆️
tui/src/ui/components/mod.rs 100.00% <ø> (ø)
tui/src/ui/mod.rs 0.00% <ø> (ø)
tui/src/ui/widgets/input_box.rs 93.22% <100.00%> (+0.91%) ⬆️
tui/src/ui/widgets/popups/notification.rs 73.07% <100.00%> (+4.89%) ⬆️
tui/src/ui/widgets/tree/mod.rs 77.93% <100.00%> (ø)
tui/src/state/mod.rs 0.00% <0.00%> (ø)
... and 14 more

... and 3 files with indirect coverage changes

@AnthonyMichaelTDM AnthonyMichaelTDM merged commit bc73256 into main Oct 11, 2024
22 of 24 checks passed
@AnthonyMichaelTDM AnthonyMichaelTDM deleted the tui-improvements branch October 11, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(tui): capture mouse events and handle them intuitively
1 participant
@AnthonyMichaelTDM