Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daemon): test client that runs on channels instead of over tcp #112

Conversation

AnthonyMichaelTDM
Copy link
Owner

this is a prerequisite for enhanced integration testing of the frontends (cli and tui so far)

@AnthonyMichaelTDM AnthonyMichaelTDM self-assigned this Sep 4, 2024
@AnthonyMichaelTDM AnthonyMichaelTDM added enhancement New feature or request rust Pull requests that update Rust code labels Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
analysis/src/chroma.rs 50.00% 1 Missing ⚠️
analysis/src/clustering.rs 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   77.52%   70.52%   -7.00%     
==========================================
  Files          90       90              
  Lines        5611     6182     +571     
==========================================
+ Hits         4350     4360      +10     
- Misses       1261     1822     +561     
Components Coverage Δ
MECOMP Core 93.37% <100.00%> (-0.03%) ⬇️
MECOMP Daemon 22.21% <100.00%> (-28.45%) ⬇️
MECOMP Storage 89.64% <ø> (-0.22%) ⬇️
SurrealQLX 85.14% <ø> (ø)
OneOrMany 99.33% <ø> (ø)
Analysis 79.93% <33.33%> (-0.21%) ⬇️
MECOMP CLI 0.00% <ø> (ø)
MECOMP TUI 88.11% <100.00%> (+0.21%) ⬆️
Files with missing lines Coverage Δ
core/src/audio/mod.rs 91.60% <100.00%> (-0.07%) ⬇️
core/src/logger.rs 100.00% <ø> (ø)
daemon/src/controller.rs 0.52% <ø> (+0.52%) ⬆️
daemon/src/lib.rs 72.72% <100.00%> (+72.72%) ⬆️
tui/src/ui/app.rs 94.68% <ø> (-0.06%) ⬇️
tui/src/ui/components/content_view/mod.rs 96.70% <ø> (ø)
tui/src/ui/components/content_view/views/album.rs 99.50% <ø> (ø)
tui/src/ui/components/content_view/views/artist.rs 99.44% <ø> (-0.01%) ⬇️
...src/ui/components/content_view/views/collection.rs 95.58% <ø> (-0.03%) ⬇️
tui/src/ui/components/content_view/views/none.rs 94.44% <ø> (ø)
... and 13 more

... and 12 files with indirect coverage changes

@AnthonyMichaelTDM AnthonyMichaelTDM merged commit 890661b into main Sep 4, 2024
19 of 24 checks passed
@AnthonyMichaelTDM AnthonyMichaelTDM deleted the 82-feattesting-implement-mock-daemon-clientserver-for-improved-testability branch September 4, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(testing): implement mock daemon client/server for improved testability
1 participant