[1.1.6] P2P: Fix IPv6 support #1594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
greg7mdp
approved these changes
Jun 6, 2025
spoonincode
approved these changes
Jun 6, 2025
Contributor
spoonincode
left a comment
spoonincode
left a comment
There was a problem hiding this comment.
From a release documentation standpoint, it's only IPv6 addresses that were broken -- hostnames with IPv6 connectivity were not broken
This was referenced Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the consolidation of address parsing in release 1.1, parsing of IPv6 addresses was broken.
Release 1.0 removed
[&]from the host. See https://github.com/AntelopeIO/spring/blob/v1.0.5/plugins/net_plugin/net_plugin.cpp#L1211This PR restores the removal of
[&]which fixes IPv6 support innet_plugin.Resolves #1588