Skip to content

[1.2.0-rc2] Performance Workflow Move Upload Out of Build Dir #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericpassmore merged 3 commits into from
May 3, 2025
Merged

[1.2.0-rc2] Performance Workflow Move Upload Out of Build Dir #1494

ericpassmore merged 3 commits into from
May 3, 2025

Conversation

@ericpassmore
Copy link
Contributor

@ericpassmore ericpassmore commented May 2, 2025 •
edited
Loading

Changes upload directory for build.tar.zst. Fixes test failing when workflow was unable to find tarred binaries build.targ.zst

Fixes #1476

@ericpassmore
Copy link
Contributor Author

ericpassmore commented May 2, 2025

Run succeeds for branch off main.
Screenshot 2025-05-02 at 12 04 13 PM

@spoonincode
Copy link
Contributor

spoonincode commented May 2, 2025

Can you link to a run that has the failure this is intended to fix?

@ericpassmore
Copy link
Contributor Author

ericpassmore commented May 2, 2025

Can you link to a run that has the failure this is intended to fix?

https://github.com/AntelopeIO/spring/actions/runs/14778790646

@ericpassmore
Copy link
Contributor Author

ericpassmore commented May 2, 2025

Can you link to a run that has the failure this is intended to fix?

I'm still testing. It could be the ./build on line 94

@ericpassmore ericpassmore marked this pull request as draft May 2, 2025 20:22
@spoonincode
Copy link
Contributor

spoonincode commented May 2, 2025

Can you link to a run that has the failure this is intended to fix?

https://github.com/AntelopeIO/spring/actions/runs/14778790646

that doesn't have anything to do with permissions. The previous job uploaded no artifact (probably shouldn't be uploading build/build.tar.zst but rather just build.tar.zst)
https://github.com/AntelopeIO/spring/actions/runs/14778790646/job/41492895077#step:3:10

@ericpassmore
Copy link
Contributor Author

ericpassmore commented May 2, 2025

Can you link to a run that has the failure this is intended to fix?

https://github.com/AntelopeIO/spring/actions/runs/14778790646

that doesn't have anything to do with permissions. The previous job uploaded no artifact (probably shouldn't be uploading build/build.tar.zst but rather just build.tar.zst) https://github.com/AntelopeIO/spring/actions/runs/14778790646/job/41492895077#step:3:10

Reverted perm change

@ericpassmore
Copy link
Contributor Author

ericpassmore commented May 3, 2025 •
edited
Loading

Three in a row successful runs.
Screenshot 2025-05-03 at 7 07 48 AM

@ericpassmore ericpassmore marked this pull request as ready for review May 3, 2025 14:08
spoonincode
spoonincode approved these changes May 3, 2025
View reviewed changes
Copy link
Contributor

@spoonincode spoonincode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember to update PR title too

@ericpassmore ericpassmore changed the title [1.2.0-rc2] Performance Workflow perm change on build [1.2.0-rc2] Performance Workflow Move Upload Out of Build Dir May 3, 2025
@ericpassmore ericpassmore merged commit b70fe3d into release/1.2 May 3, 2025
48 checks passed
@ericpassmore ericpassmore deleted the performance-workflow-fix-test-build-extraction branch May 3, 2025 20:20
@ericpassmore ericpassmore mentioned this pull request May 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@heifner heifner heifner approved these changes

@spoonincode spoonincode spoonincode approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ericpassmore @spoonincode @heifner