Skip to content

Conversation

@ericpassmore
Copy link
Contributor

@ericpassmore ericpassmore commented Apr 29, 2025

Update the CICD system build from eosnetworkfoundation/eos-system-contracts to vaultafoundation/system-contracts

  • Updated the json defaults with a non-eos name
  • Updated the build yaml repository reference for system contracts
  • Updates the variable names and descriptions to a non-eos name

Related to Issue #1358

@ericpassmore ericpassmore linked an issue Apr 29, 2025 that may be closed by this pull request
@ericpassmore ericpassmore added the CICD Anything dealing with the CI workflow behavior label Apr 29, 2025
@greg7mdp
Copy link
Contributor

greg7mdp commented Apr 29, 2025

Maybe update the LICENSE file too:

https://github.com/VaultaFoundation/system-contracts/blob/0365e125875033af01e999d537dd70c82189225a/LICENSE#L1

also CONTRIBUTING.md, multiple references to eos-system-contracts.

@greg7mdp
Copy link
Contributor

greg7mdp commented Apr 29, 2025

References in docs as well:

./docs/04_guides/03_how-to-stake.md:* Ensure the reference system contracts from `eos-system-contracts` repository is deployed and used to manage system resources
./docs/04_guides/08_how-to-configure-the-powerup-resource-model.md:1. Build [eos-system-contracts](https://github.com/eosnetworkfoundation/eos-system-contracts) with `powerup` code.
./docs/04_guides/05_how-to-create-issue-and-transfer-a-token.md:git clone https://github.com/eosnetworkfoundation/eos-system-contracts --branch release/3.1 --single-branch
./docs/04_guides/05_how-to-create-issue-and-transfer-a-token.md:cd eos-system-contracts/contracts/eosio.token
./docs/04_guides/05_how-to-create-issue-and-transfer-a-token.md:cleos set contract eosio.token CONTRACTS_DIR/eos-system-contracts/contracts/eosio.token --abi eosio.token.abi -p eosio.token@active
./docs/04_guides/04_how-to-vote.md:* Ensure the reference system contracts from `eos-system-contracts` repository is deployed and used to manage system resources
./docs/04_guides/02_how-to-buy-ram.md:* Ensure the reference system contracts from `eos-system-contracts` repository is deployed and used to manage system resources
./docs/03_build-and-deploy.md:For building instructions, refer to the [Building](https://github.com/eosnetworkfoundation/eos-system-contracts#building) section.
./docs/01_key-concepts/01_system.md:At the genesis of the EOS blockchain, there was only one account present, `eosio` account, which was and still is the main `system account`. During the EOS blockchain bootstrap process other `system account`s, were created by `eosio` account, which control specific actions of the `system contract`s. You can see them listed in the [About System Contract](../index.md#system-contracts-defined-in-eos-system-contracts) section.
./docs/01_key-concepts/07_powerup_model.md:* The `days` which must always match `state.powerup_days` specified in the [PowerUp configuration settings](https://github.com/eosnetworkfoundation/eos-system-contracts/blob/7cec470b17bd53b8c78465d4cbd889dbaf1baffb/contracts/eosio.system/include/eosio.system/eosio.system.hpp#L588).
./docs/index.md:## System contracts defined in eos-system-contracts
./docs/index.md:The `eos-system-contracts` repository contains the system contracts encapsulating the base functionality for the EOS blockchain.

and in contract code:

https://github.com/eosnetworkfoundation/eos-system-contracts/blob/0365e125875033af01e999d537dd70c82189225a/contracts/eosio.system/include/eosio.system/eosio.system.hpp#L1322-L1326

https://github.com/eosnetworkfoundation/eos-system-contracts/blob/0365e125875033af01e999d537dd70c82189225a/contracts/eosio.system/src/rex.cpp#L979-L998

Also:

./contracts/CMakeLists.txt:set(ICON_BASE_URL "https://raw.githubusercontent.com/eosnetworkfoundation/eos-system-contracts/main/contracts/icons")

and

./CMakeLists.txt:message(STATUS "Building eos-system-contracts v${VERSION_FULL}")
./build.sh:printf "\t=========== Building eos-system-contracts ===========\n\n"

@ericpassmore
Copy link
Contributor Author

ericpassmore commented Apr 29, 2025

Org decision not to update the License files. This is because out legal name may not have changed.

Still should update the name of the repo, right: eos-system-contracts => system-contracts

@ericpassmore
Copy link
Contributor Author

Full rollup issue for Rename tracked in engineering issue # 113. Best to move these references to one of the sub issues.
VaultaFoundation/engineering#113

References in docs as well:

./docs/04_guides/03_how-to-stake.md:* Ensure the reference system contracts from `eos-system-contracts` repository is deployed and used to manage system resources
./docs/04_guides/08_how-to-configure-the-powerup-resource-model.md:1. Build [eos-system-contracts](https://github.com/eosnetworkfoundation/eos-system-contracts) with `powerup` code.
./docs/04_guides/05_how-to-create-issue-and-transfer-a-token.md:git clone https://github.com/eosnetworkfoundation/eos-system-contracts --branch release/3.1 --single-branch
./docs/04_guides/05_how-to-create-issue-and-transfer-a-token.md:cd eos-system-contracts/contracts/eosio.token
./docs/04_guides/05_how-to-create-issue-and-transfer-a-token.md:cleos set contract eosio.token CONTRACTS_DIR/eos-system-contracts/contracts/eosio.token --abi eosio.token.abi -p eosio.token@active
./docs/04_guides/04_how-to-vote.md:* Ensure the reference system contracts from `eos-system-contracts` repository is deployed and used to manage system resources
./docs/04_guides/02_how-to-buy-ram.md:* Ensure the reference system contracts from `eos-system-contracts` repository is deployed and used to manage system resources
./docs/03_build-and-deploy.md:For building instructions, refer to the [Building](https://github.com/eosnetworkfoundation/eos-system-contracts#building) section.
./docs/01_key-concepts/01_system.md:At the genesis of the EOS blockchain, there was only one account present, `eosio` account, which was and still is the main `system account`. During the EOS blockchain bootstrap process other `system account`s, were created by `eosio` account, which control specific actions of the `system contract`s. You can see them listed in the [About System Contract](../index.md#system-contracts-defined-in-eos-system-contracts) section.
./docs/01_key-concepts/07_powerup_model.md:* The `days` which must always match `state.powerup_days` specified in the [PowerUp configuration settings](https://github.com/eosnetworkfoundation/eos-system-contracts/blob/7cec470b17bd53b8c78465d4cbd889dbaf1baffb/contracts/eosio.system/include/eosio.system/eosio.system.hpp#L588).
./docs/index.md:## System contracts defined in eos-system-contracts
./docs/index.md:The `eos-system-contracts` repository contains the system contracts encapsulating the base functionality for the EOS blockchain.

and in contract code:

https://github.com/eosnetworkfoundation/eos-system-contracts/blob/0365e125875033af01e999d537dd70c82189225a/contracts/eosio.system/include/eosio.system/eosio.system.hpp#L1322-L1326

https://github.com/eosnetworkfoundation/eos-system-contracts/blob/0365e125875033af01e999d537dd70c82189225a/contracts/eosio.system/src/rex.cpp#L979-L998

Also:

./contracts/CMakeLists.txt:set(ICON_BASE_URL "https://raw.githubusercontent.com/eosnetworkfoundation/eos-system-contracts/main/contracts/icons")

and

./CMakeLists.txt:message(STATUS "Building eos-system-contracts v${VERSION_FULL}")
./build.sh:printf "\t=========== Building eos-system-contracts ===========\n\n"

@ericpassmore ericpassmore merged commit 654215b into release/1.2 Apr 29, 2025
36 checks passed
@ericpassmore ericpassmore deleted the github-org-rename-tgt-1.2 branch April 29, 2025 18:27
@heifner heifner changed the title github org rename to vaultafoundation/system-contracts [1.2.0-rc2] github org rename to vaultafoundation/system-contracts Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Anything dealing with the CI workflow behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update CI/CD with new system-contract repository name

5 participants