Support truncate-at-block with terminate-at-block #1457
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When syncing, a node can load up the fork database with many blocks ahead of the current head. The
terminate-at-blockoption terminates when the head reaches the specifiedterminate-at-block. On restart of the node afterterminate-at-blockthis can be confusing as the node can process the blocks out of the fork database on restart. To avoid having these extra blocks in the fork database on shutdown,truncate-at-blockcan now be specified along withterminate-at-block. On shutdown due to aterminate-at-block, iftruncate-at-blockis specified then the fork database will have all blocks beyondtruncate-at-blockremoved.Note: Existing
terminate-scenarios-test.pycontinues to testterminate-at-blockwithouttruncate-at-block.nodeos_read_terminate_at_block_test.pywhich expects the restarted node not to have extra blocks has been updated to usetruncate-at-blockwithterminate-at-block.Resolves #1365