Skip to content

SC: Make sure return value is retained if set_call_return_value() is called before eosio_exit() #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
linh2931 merged 2 commits into from
Apr 23, 2025
Merged

SC: Make sure return value is retained if set_call_return_value() is called before eosio_exit() #1427

linh2931 merged 2 commits into from
Apr 23, 2025

Conversation

@linh2931
Copy link
Contributor

@linh2931 linh2931 commented Apr 22, 2025

Make sure return value is retained if set_call_return_value() is called before eosio_exit().

Add a test to verify it works.

Resolves #1372

@linh2931 linh2931 requested review from heifner and spoonincode April 22, 2025 19:11
@linh2931 linh2931 linked an issue Apr 22, 2025 that may be closed by this pull request
SC: lost return value when eosio_exit is called #1372
Closed
Base automatically changed from ro_trace_fix to sync_call April 23, 2025 23:37
@linh2931 linh2931 merged commit 128eef3 into sync_call Apr 23, 2025
36 checks passed
@linh2931 linh2931 deleted the eosio_exit_fix branch April 23, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@heifner heifner heifner approved these changes

@spoonincode spoonincode spoonincode approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SC: lost return value when eosio_exit is called

4 participants

@linh2931 @heifner @spoonincode