SC: Hide max_sync_call_depth and max_sync_call_data_size in the return value of get_consensus_parameters if sync_call protocol feature is not activated #1331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue of get_consensus_parameters is sync_call protocol feature is not activated
spoonincode
reviewed
Apr 7, 2025
tests/chain_plugin_tests.cpp
Outdated
| chain_config_v2 v2config; | ||
| from_variant(parms.chain_config, v2config); | ||
|
|
||
| BOOST_TEST(v2config.max_action_return_value_size == t.control->get_global_properties().configuration.max_action_return_value_size); |
Contributor
There was a problem hiding this comment.
This line looks like it might be a copy/paste from above -- don't you want to check that max_sync_call_depth and max_sync_call_data_size match -- not max_action_return_value_size?
Contributor
Author
There was a problem hiding this comment.
Thanks! I should have verified the returned values of max_sync_call_depth and max_sync_call_data_size
heifner
approved these changes
Apr 7, 2025
spoonincode
reviewed
Apr 7, 2025
| to_variant(db.get_global_properties().configuration.base(), results.chain_config); //chain_config_v1 | ||
| else | ||
| to_variant(db.get_global_properties().configuration.base(), results.chain_config); //chain_config_v0 | ||
| to_variant(db.get_global_properties().configuration.v0(), results.chain_config); //chain_config_v0 |
Contributor
There was a problem hiding this comment.
Alternatively base().base() if you don't want to add the new v0(). I don't have a strong preference either way
…h those on the chain
spoonincode
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not include
max_sync_call_depthandmax_sync_call_data_sizein the return value ofget_consensus_parametersif sync_call protocol feature is not activated. This is consistent with the behavior of #1284.Resolves #1289