Interrupt speculative transaction when block received #1330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Note:start |
…interrupt the process_block
…ition can cause issues
greg7mdp
approved these changes
Apr 9, 2025
| my->chain_plug->chain().interrupt_apply_block_transaction(); | ||
| if (my->_is_savanna_active) { // interrupt during transition causes issues, so only allow after transition | ||
| if (fork_db_add_result == fork_db_add_t::appended_to_head) { | ||
| fc_tlog(_log, "new head block received"); |
Contributor
There was a problem hiding this comment.
Would it make sense to have this message?
Suggested change
| fc_tlog(_log, "new head block received"); | |
| fc_tlog(_log, "new head block received, interrupting transaction"); |
greg7mdp
approved these changes
Apr 9, 2025
linh2931
reviewed
Apr 15, 2025
linh2931
reviewed
Apr 15, 2025
Contributor
linh2931
left a comment
linh2931
left a comment
There was a problem hiding this comment.
Do we have tests to verify the new interruption?
Contributor
Author
Every savanna integration test exercises the interrupt. Every incoming block has the potential to interrupt a transaction. |
linh2931
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interrupt speculative transaction execution when a block is received or on ctrl-c.
Along with the existing interrupt of transactions in a block being validated, also interrupt speculative trxs so that processing of incoming block can start immediately.
Example:
Resolves #1170