Skip to content

PerformanceHarness version roll back ambiguity #49

@spoonincode

Description

@spoonincode

PerformanceHarness configures itself differently based on what nodeos --full-version returns. Its behavior is altered if the version begins with v2 or v4 with the assumption if it's not one of those versions it must be the "latest". So for spring v1 this code still does what is expected ("latest"), but spring v2 will not follow the expected path. Examples,

if "v2" in self.nodeosVers:
validationNodeSpecificNodeosStr += '--plugin eosio::history_api_plugin --filter-on "*" '
else:
#If prodsEnableTraceApi, then Cluster configures all nodes with trace_api_plugin so no need to duplicate here

if "v4" in self.nodeosVers:
apiNodeSpecificNodeosStr += f"--read-only-threads {self.apiNodesReadOnlyThreadCount} "
if apiNodeSpecificNodeosStr:
self.specificExtraNodeosArgs.update({f"{nodeId}" : apiNodeSpecificNodeosStr for nodeId in self._apiNodeIds})

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Status

Done

Relationships

None yet

Development

No branches or pull requests

Issue actions