Remove max-nonprivileged-inline-action-size option #1645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…action_size limit and add new test for 512k limit
heifner
changed the title
linh2931
approved these changes
Sep 15, 2023
Contributor
linh2931
left a comment
linh2931
left a comment
There was a problem hiding this comment.
I like your PR description!
greg7mdp
reviewed
Sep 15, 2023
| @@ -453,7 +450,7 @@ namespace eosio { namespace testing { | |||
| class tester : public base_tester { | |||
| public: | |||
| tester(setup_policy policy = setup_policy::full, db_read_mode read_mode = db_read_mode::HEAD, std::optional<uint32_t> genesis_max_inline_action_size = std::optional<uint32_t>{}, std::optional<uint32_t> config_max_nonprivileged_inline_action_size = std::optional<uint32_t>{}) { | |||
Contributor
There was a problem hiding this comment.
should you remove the parameter as well, or maybe change the name to unused.
std::optional<uint32_t> config_max_nonprivileged_inline_action_size = std::optional<uint32_t>{}
Contributor
Author
There was a problem hiding this comment.
Thanks, not sure how my search missed that.
greg7mdp
approved these changes
Sep 15, 2023
linh2931
approved these changes
Sep 15, 2023
heifner
deleted the
GH-1614-rm-max-non-privileged-inline-action-size
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the option
max-nonprivileged-inline-action-sizemax_inline_action_sizeprovides protection against abuse.524287. https://bloks.io/account/eosio?loadContract=true&tab=Tables&account=eosio&scope=eosio&limit=100&table=globalResolves #1614