-
Notifications
You must be signed in to change notification settings - Fork 42
Add bitset support in abi.
#352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The cmake build have the same file included twice with different paths:
```
/home/greg/github/enf/cdt/build_clang18_debug/bin/cdt-cpp -D_LIBCPP_BUILDING_LIBRARY -I/home/greg/github/enf/cdt/libraries/libc/cdt-musl/include -I/home/greg/github/enf/cdt/libraries/libc/cdt-musl/src/internal -I/home/greg/github/enf/cdt/libraries/libc/cdt-musl/src/crypt -I/home/greg/github/enf/cdt/libraries/libc/cdt-musl/arch/eos -I/home/greg/github/enf/cdt/libraries/libc++/cdt-libcxx/include -I/home/greg/github/enf/cdt/libraries -O3 -Wall -no-missing-ricardian-clause -g -g -std=gnu++17 -MD -MT eosiolib/CMakeFiles/eosio.dir/eosiolib.cpp.obj -MF eosiolib/CMakeFiles/eosio.dir/eosiolib.cpp.obj.d -o eosiolib/CMakeFiles/eosio.dir/eosiolib.cpp.obj -c /home/greg/github/enf/cdt/libraries/eosiolib/eosiolib.cpp
In file included from /home/greg/github/enf/cdt/libraries/eosiolib/eosiolib.cpp:3:
In file included from /home/greg/github/enf/cdt/libraries/eosiolib/contracts/eosio/system.hpp:9:
In file included from /home/greg/github/enf/cdt/libraries/eosiolib/contracts/eosio/../../core/eosio/name.hpp:9:
In file included from /home/greg/github/enf/cdt/libraries/eosiolib/core/eosio/reflect.hpp:3:
In file included from /home/greg/github/enf/cdt/build_clang18_debug/bin/../include/bluegrass/meta/refl.hpp:11:
/home/greg/github/enf/cdt/build_clang18_debug/bin/../include/eosiolib/core/eosio/print.hpp:78:16: error: redefinition of 'printhex'
inline void printhex( const void* ptr, uint32_t size) {
^
/home/greg/github/enf/cdt/libraries/eosiolib/core/eosio/print.hpp:78:16: note: previous definition is here
inline void printhex( const void* ptr, uint32_t size) {
^
```
|
The output ABI version needs to be updated. Did we make a conclusive decision on 1.3 vs 2.0 🥴 ? idk if we should (or if it's worth) trying to detect if any 1.3/2.0 features are being used and only output the new version in that case. |
|
Still need to determine what to do about generated ABI version. |
spoonincode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ABI versioning stuff will be handled separately in #355
Resolves #337.
Example contract with
hiaction taking abitset:calling
hiaction