Skip to content

Conversation

@spoonincode
Copy link
Contributor

appbase requires c++17 which was first supported in cmake 3.8 so bump minimum version supported to 3.8. Also opt in for cmake policies through 3.31 to silence a warning that is showing up in latest cmake

CMake Deprecation Warning at libraries/appbase/CMakeLists.txt:2 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

(alternatively could possibly just opt in to CMP0167 instead of all the way through 3.31 but this seems fine..)

@spoonincode spoonincode merged commit 2546dbc into main Jan 8, 2025
2 checks passed
@spoonincode spoonincode deleted the cmake_min_bump branch January 8, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants