pre-commit hooks don't work with 2.3.37

[idahlke-blacksky]

Pre-commit hooks are installed from github directly. The source for tag 2.3.37 identifies the library version as 2.3.32 while the actual library install (via pypi) is identifying itself as 2.3.37. This has been true for a few past versions as well based on a quick look at the source. So in my environment nbdev is being installed at 2.3.37 with fastcore at 1.8. But the precommit hooks, while directed to 2.3.37 are triggering installs identifying themselves as 2.3.32 and 1.8. Theoretically I have the source for 2.3.37, but the version is just mislabeled, except that the hooks don't work.

The error below indicates the hook is trying to use source that hasn't been updated for fastcore 1.8, but I'm not sure why. I've uninstalled and cleaned the cache for my hooks before reinstalling. nbdev and fastcore work fine together when I call nbdev_clean/export manually. Those installs are coming from conda->pip and identify as their intended versions according to the init.py files in the conda sitepackages folder.

I thought this was a caching problem until I saw the 2.3.32 identifier in the github source.

pre-commit run
[WARNING] Unstaged files detected.
[INFO] Stashing unstaged files to /home/idahlke/.cache/pre-commit/patch1742504830-18983.
nbdev_clean..............................................................Failed

• hook id: nbdev_clean
• exit code: 1

Traceback (most recent call last):
File "/home/idahlke/.cache/pre-commit/repot0rqgexy/py_env-python3.10/bin/nbdev_clean", line 5, in
from nbdev.clean import nbdev_clean
File "/home/idahlke/.cache/pre-commit/repot0rqgexy/py_env-python3.10/lib/python3.10/site-packages/nbdev/init.py", line 4, in
from .showdoc import show_doc
File "/home/idahlke/.cache/pre-commit/repot0rqgexy/py_env-python3.10/lib/python3.10/site-packages/nbdev/showdoc.py", line 10, in
from fastcore.dispatch import TypeDispatch
File "/home/idahlke/.cache/pre-commit/repot0rqgexy/py_env-python3.10/lib/python3.10/site-packages/fastcore/dispatch.py", line 2, in getattr
raise ImportError(
ImportError: Could not import 'path' from fastcore.dispatch - this module has been moved to the fasttransform package.
To migrate your code, please see the migration guide at: https://answerdotai.github.io/fasttransform/fastcore_migration_guide.html

[idahlke-blacksky]

I think this might be a larger problem with the release mechanism. It looks like 2.3.37 was released from the branch master, but all of the content intended for that release is not on master, it is on main.

[idahlke-blacksky]

Sure enough I've been able to circumvent this issue by installing pre-commit hooks directly from c1befba10bb2748b61dde149556348f211c73081 (the 2.3.37 commit to main) rather than the 2.3.37 tag (which is to on master).

[idahlke-blacksky]

I suspect this line is to blame

nbdev/settings.ini

Line 10 in be3fd22

branch = master

.

[hwaterer]

Running pre-commit autoupdate --bleeding-edge --repo https://github.com/answerdotai/nbdev resolved this for me.

[benoit-cty]

Running pre-commit autoupdate --bleeding-edge --repo https://github.com/answerdotai/nbdev resolved this for me.

Thanks for sharing that. It doesn't work for me. Do I have to run others commands ?

[benoit-cty]

I suspect this line is to blame

nbdev/settings.ini

Line 10 in be3fd22
branch = master
.

Nice catch, I open a PR to change that : #1513

[benoit-cty]

This config works for me, thanks to @idahlke-blacksky :

- repo: https://github.com/AnswerDotAI/nbdev
  rev: be3fd2266e4dcd605b60d7217a838810809e857f
  hooks:
  - id: nbdev_clean

[hwaterer]

That was the rev that pre-commit autoupdate --bleeding-edge --repo https://github.com/answerdotai/nbdev gave me when I ran the command on March 19.