Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: remove hx_replace_url repeated key #600

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

pratapvardhan
Copy link
Contributor

@pratapvardhan pratapvardhan commented Dec 10, 2024


name: Pull Request
about: remove hx_replace_url repeated key from components's hx_attrs_annotations dict
title: '[PR] '
labels: 'cleanup'
assignees: ''


Related Issue
[skip]

Proposed Changes
Remove hx_replace_url repeated key from components's hx_attrs_annotations dict

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Cleanup

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information
[none]

Copy link

gitnotebooks bot commented Dec 10, 2024

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/600

@pratapvardhan
Copy link
Contributor Author

cc @jph00 this is a tiny cleanup, would need your approval for workflow to run, I can't add reviewers directly.

@jph00
Copy link
Contributor

jph00 commented Dec 22, 2024

Well spotted :)

@jph00 jph00 merged commit 66cbf72 into AnswerDotAI:main Dec 22, 2024
@pratapvardhan pratapvardhan deleted the pv-ref branch December 23, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants