update init script #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
init script is outdated. docker daemon does not startup with latest package
| start on filesystem | ||
| start on (filesystem and net-device-up IFACE!=lo) | ||
| stop on runlevel [!2345] | ||
| limit nofile 524288 1048576 |
There was a problem hiding this comment.
Seems too arbitrary. Would be nice to control what limits to use or at least these limit values.
There was a problem hiding this comment.
This configuration sometimes seems to be needed as far as I see in moby/moby#5939 and moby/moby#4455 (systemd), corresponding fix for upstart is moby/moby#4749 , moby/moby@119839d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
init script seems to be outdated and it will override it wrongly now.
due to this docker daemon could not startup with below error log with latest docker-engine now in my ubuntu environment.
Error starting daemon: Devices cgroup isn't mounted